Mahesh Gupta

Results 11 comments of Mahesh Gupta

Looks like Oracle used in buildbot do not support collation changes , hence my unit test skipped ``` test_alter_unique_key_db_collation (schema.tests.SchemaTests.test_alter_unique_key_db_collation) ... skip (0.198s) ``` How we test it now ?

As per https://docs.oracle.com/en/error-help/db/ora-43923/ Collation are divided into groups and **Group 1**: BINARY, USING_NLS_COMP, USING_NLS_SORT, USING_NLS_SORT_CS, USING_NLS_SORT_VAR1, and USING_NLS_SORT_VAR1_CS **Group 2**: BINARY_CI, USING_NLS_SORT_CI, and USING_NLS_SORT_VAR1_CI **Group 3**: BINARY_AI, USING_NLS_SORT_AI, and USING_NLS_SORT_VAR1_AI...

https://github.com/django/django/pull/18049#issuecomment-2041080312 Yes I didnt fix the issue when primary key has foreign key reference checks. But stil this patch can fix collation change on an inxdexed, unique column. I will...

Closing this as i am unable to use oracle to verify all corner cases.

@dvora-h Can you please take a look.

@vladvildanov Can you please take a look ?

Hello, @vladvildanov @gerzse , Can anyone look in to this PR ?