Mohamed Mahfouz
Mohamed Mahfouz
Github, generate report Edit: ignore report below
Github, generate report
Github, generate report
I generated two report - report-1 (no diff) with this [config](https://gist.githubusercontent.com/mahfouz72/afd57aa6e51ca161b7927acd959e5211/raw/e82a7576e6372a18bb4794217b6713b475f0e4f9/check.xml) to check that the check behavior didn't change when `validateBetweenScopes` is on - report-2 (expected diff) with this [config](https://gist.githubusercontent.com/mahfouz72/ce878f7db10dd474a7f6aa53ada50c7c/raw/68d7ec7bcef08b49d6deaa712d2e18cf8c328dcd/check1.xml)...
> If you are going to give this summary for reviewers, I highly recommend you copy the report links too. This helps that we don't have to hunt them down...
@nrmancuso are we ok on this?
@nrmancuso @rnveach finally [report](https://mahfouz72.github.io/) with this PR as base and patch is the same but with hardcoding the mutations no diff found on 26 projects so now we will merge...
@rnveach is this still valid? and if it is can you explain to me why you expect a violation here isn't it supposed to not check distance in different scope
> I cannot turn on validateBetweenScopes because it acts as if the braces do not exist and with a distance of 1 it will ask for variables to be moved...