Mark Larah
Mark Larah
@hwillson @brainkim @jerelmiller is this still relevant? I see 3.7.7 looks to have improved things but i haven't tested it out yet: https://github.com/apollographql/apollo-client/releases/tag/v3.7.7 > Log a warning to the console...
Thanks for the response @meiamsome! I really like the stopgap solution, nice and sneaky :) As for the class of concerns raised with likely any API here, there would indeed...
https://github.com/depcheck/depcheck does this and it's really useful - would be neat to have as an eslint rule though.
@yurishkuro >> a segment is on the CP if making the execution of that segment shorter would make the whole request shorter > I believe Jaeger's depiction meets this definition....
Just to elaborate on this: > All three foo spans are siblings in your trace (which does not exactly match the code structure where, one could argue, foo3 is a...
> You are basing that on your knowledge of the code, but that's not reflected in the trace. I think that's precisely the point i'm getting at here! Jaeger fundamentally...
> CP is a heuristic Ah I think "CP is a heuristic" is probably the key bit of information i was missing. TIL. Purely looking at the UI this wasn't...
Sounds like a good idea. I would also encourage exploring the idea of coloring the CP differently in cases where there is ambiguity (such as here). In a world where...
@benjie I don't have write access to this PR since I wasn't the original author -- do you think we could merge in https://github.com/graphql/graphql-js/pull/4422 and then https://github.com/magicmark/graphql-js/pull/1 to collapse the...
a bare `.__typename` isn't something that would/could exist in a GraphQL operation right? I can't think what use cases there would be to need to support that as something we'd...