qinmu

Results 15 comments of qinmu

As @sami-baadarani said, the first svg element does not contain a height or width values. After adding width or height, they both work well. @sandeep-gh ![Screen Shot 2022-07-08 at 9...

Thanks. After I upgrade my node version, it works!

Runtime compatible code is unavoidable which could pump up the size. A waring "Please upgrade to higher node version" instead of an error would be more friendly to users. I...

isElement里!!(obj && obj.nodeType === 1)为什么不能直接写成obj && obj.nodeType === 1

嗯,也就是说保证返回值是布尔值。只是实际开发的时候if表达式求值后也是布尔值,所以也就没这样写了。 2017-12-12 15:26 GMT+08:00 zjp6049 : > 看来两遍只能说看懂了代码想表达什么,要我自己写的话肯定会懵逼。 > 还有~~为什么没有直接点下一篇的链接啊哈哈哈 > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it...

> Idk if a "generic" `rattler_progress` makes sense. The implementation is very specific. Id much rather have a slimmed down version of progress reporting in the rattler_upload code itself that...

> Hey @magentaqin I'll take this PR over and get it merged! I'll remove some changes from the S3 upload because IMO progress bar shoudl go to a different PR....

> Hey @remimimimimi @magentaqin, co-founder of @CodSpeedHQ here. > > There is an issue on our side with macro runners with this repository, for some reason we are not able...

> Great work! Please consider my suggestions in your next commit. Also, could you change the title of the PR into "translation: ...", so it is easier to track. Thank...