Shlok Patel

Results 24 comments of Shlok Patel

I'll try to fix all the open issues on this repository. Thanks !!

@marcpires I'll try to work and merge any pull request if you have any ideas.

@amanagr I have made most of the changes. I'm facing problem with keyboard navigation. ![Recent topics - Zulip Dev - Zulip](https://user-images.githubusercontent.com/51414879/152563795-91b0cf70-2edb-45d1-b4be-13211bce3201.gif)

@amanagr I have update the commit with private tests as well, can you please have a look at it?

@amanagr no, they are all present in this [commit](https://github.com/zulip/zulip/commit/3559a6e41f09148f28bb42edbe0e20c9439ab2f1) as time asked me to break the commit into small changes, so it would be easy to review the code and...

@amanagr It was the part of the pr. I rebased this pr, as i was to break single commit into small commits.

@amanagr @timabbott apologies for the delay. I have update all the code here including the ui.

@timabbott I have tweaked the tests current tests, they work with full coverage, but special tests for private messages are yet to be added.

@timabbott > Also, is the first commit something we could merge independently of the second one to reduce the size of this PR and thus merge conflict risk? I think...