Adam Cigánek
Adam Cigánek
I'd step up, why not :) Is the problem only in capybara-envjs or is it envjs itself?
Cool! Let me know if you need someone to test it.
Yes, I know about this. It's even in the TODO section of the README :) It's unlikely I fix it anytime soon (no time + the issue is not critical...
> If SendFut is polled and returns Poll::Pending, it may be received by a receiver at any point. Bit confused about this. Does this mean that if `SendFut` is polled...
> Yes, indeed. ... I see. So that means `flume::Sender` is not "cancel safe" in the same sense that `tokio::mpsc::Sender` is. That is, when the `send_async` future is cancelled (dropped),...
> Could the RAII guard be created before the send occurs? The worker thread would need to deal with the potential for spurious messages, however. Yes exactly. That could create...
@xfbs : I've rebased it already in my local temp branch: https://github.com/madadam/sqlx/commits/patches. Feel free to use it.
Good point, I haven't considered it. Guess that makes it not quite as trivial as I though...
I think to properly implement this, we would have to track the number of senders instead of just a single bit indicating closed channel. Thus we won't be able to...
Yeah, that might work although I'm not sure 32 bits is enough for the version (but maybe some wrap-around tricks can be used). But I wonder, do they actually need...