Mackenzie Salisbury

Results 52 comments of Mackenzie Salisbury

Cheers @mfogel, I will get some test cases. Our only confirmed failing cases are large datasets from a production environment, which I can't share for IP reasons. We have some...

@Athorcis I get the same issue, and it seems to propagate from earlier in the code. At this line: [https://github.com/mfogel/polygon-clipping/blob/203699f5f39fedbdaa1b44ed2ad75f79309d8362/src/sweep-line.js#L53](https://github.com/mfogel/polygon-clipping/blob/203699f5f39fedbdaa1b44ed2ad75f79309d8362/src/sweep-line.js#L53) I get these evaluations: ``` > node.key == this.tree.prev(node).key true...

UPDATE: I've just fixed this but leaving it for reference. It was the adult content filter on OSX. Adding an exception rule did not work, I had to disable the...

> What firewall/ content filtering you are using??Can you please provide me details? It's the one built into OSX under Screen Time. There's an option to disable adult web content....

Just chipping in, we are using this type of setup on v5 (one or more MemoryRouters inside a BrowserRouter) to implement navigation inside modals and menus that's independent of the...

> Thanks for your PR @macksal. > > We've just hit this bug for the first time after years of using `polygon-clipping` and your fix resolved our issue. Are you...

If you’re able to provide the raw data which is causing the error, I’d be happy to create a unit test from it. ________________________________ From: max-higharc ***@***.***> Sent: Tuesday, December...

@mfogel I added the test case from @max-higharc to this branch.

Hit this today too, seems like a straightforward fix that would save others some time

> If there's interest in some kind of finally() function, I could open up a PR to add it. I'm thinking `finally()` would be called with the final `Result`, and...