Maciej Warszawski

Results 14 comments of Maciej Warszawski

@vexx32 it does not work the way you've described it in second bullet. if you have `psd1` you can omit `FunctionsToExport ` you can put `*` there, it does not...

what if string variables ${} would be converted to whildcard, test name would be converted to ```javascript /is dynamic test name [.]+ [0-9]+/ ``` and then on mouse over toMatchSnapshot...

@nblumhardt, I have spare time and I have some questions regarding this issue. ## summary of current state of code: on ```WriteTo``` we have two methods, one with ```ITextFormatter``` and...

this helps definitely, I'll move current method and mark is as obsolete editor browsable never. As I understand source breaking change is acceptable? in this case I'll make sure that...

@nblumhardt is there a reason why ```FileSink``` ```SharedFileSink``` ```RollingFileSink``` opens file differently? I think it is better to open file in constructor, because I will be obvious that something is...

@nblumhardt another strange thing for infinite interval we will have ```_nextCheckpoint``` set to 30 minutes form now https://github.com/serilog/serilog-sinks-file/blob/5b52dd29f0547b2c5a11caa4f6488d9de6d77683/src/Serilog.Sinks.File/Sinks/File/RollingFileSink.cs#L116 after more then 30 minutes when we log something, file will be...

@nblumhardt I'll make absolutelly minimal changes to this PR, since I cannot swallow exception in AuditTo some change I have to make, to be sure we have a successfully logged...

@kzu this is interesting problem, but correct me if I'm wrong, restore can use floating version and pack is using version that was restored at the time, that is in...

@fbartho do you have babel in your build config? I have no problems with jest, because I have ts transpiler only, when I use it with webpack ts and babel,...

ok I have some info regarding subject. https://www.typescriptlang.org/docs/handbook/declaration-files/library-structures.html thats the reason I think > **The Impact of ES6 on Module Call Signatures** > Many popular libraries, such as Express, expose...