Marek Bartoš

Results 125 comments of Marek Bartoš

If I for example installed phpstan and phpunit as a tools, would I be able to analyse phpunit tests with phpstan? From what I understand, phpstan would know nothing about...

Such rule can be generalized for any operator. ```php $message .= $spaces . $line . ($key === $lastLine ? '' : PHP_EOL); ``` ```php $number = $n1 + $n2 +...

Namespaced function cannot be called without importing function or using its namespace. If it works for you without it, then the function must be defined in both global and Symfony\......

Sorry, apparently I am unable to read properly today. Local ignore should imho work. But it would be imho best to extract functions into own file, even though you are...

Btw, it's already implemented by phpstan strict rules https://phpstan.org/r/2966deda-b4e9-4d76-ada9-2c9b6467c857

PHPCS rules in general don't follow inheritance rules and it would break in case final class implements protected method required by parent. But it should be simple to do with...

Meanwhile paths in `build/infection.json` are relative to project root (cwd) and not the file itself. Following config works correctly: ```json { "source": { "directories": [ "src" ] }, "phpUnit": {...

I understand that such BC break could be really confusing for others but in long-term it's imho better to do so to be consistent with rest of the php tooling,...

The command `--coverage` option is relative to config file instead of working directory. Do you suggest to keep that behavior? The option Psalm have is imho only for paths inside...

Unfortunatelly it currently is relative to a config file. I am thinking if `resolveFromConfigFile` shouldn't be something like `resolveFromWhereDefined` and include also paths in command, but it cannot work for...