maayanorner

OpenSpiel Implementation of Diplomacy

3

Hi, I was wondering - is there a plan to include Diplomacy in OpenSpiel? Anthony et al. wrote a (beautiful) paper about SBR which cites OpenSpiel - and I was...

Improve documentation

5

I think the documentation could be improved, I'm using your boilerplate REST API and this (great) module is rather confusing to me. I think what it really lacks is a...

Incorrect docstring in policy_gradient.py

4

https://github.com/deepmind/open_spiel/blob/f4ae28033cc1f92ca4cc9f8bc87477ba9c8c4237/open_spiel/python/algorithms/policy_gradient.py Hi, The docstring states the critic learning rate is 0.001, but it really defaults to 0.01. It has the same issue in PPO, etc., I guess it's related to...

https://github.com/nlp-uoregon/trankit/blob/f6b916b39decb3bc8b87b0c4bf100f3de41e3d24/trankit/pipeline.py#L980 The issue is self-explanatory, this behavior is a bit unexpected. I am not sure if it's a bug or a design decision. It happens in _lemmatize_sent as well. ```...