Martin
Martin
Thanks for all the advice, it's been really helpful! With the tests, would you suggest making seperate files for each one or loosely grouping them?
> Also, could the tests all be moved to `fast`? they'd be able to use mocks for `nvm ls-remote` calls, and as long as the dynamically-looked-up expected versions were fake-installed...
> > however I'm not sure how to do fake installs (have you got any existing functions to do that?) > > i do! grep for `make_fake_node` Hmm, I tried...
If you'd like I can prepend that to all of the `nvm install` statements anyway
I'm not quite sure how to mock `nvm_ls_remote`, so I've added 3 todo notes as to where it needs to be ran; All of the tests run fine, just some...
Any news with getting this merged?
Sorry this thread is more than a year old so I don't think I'm going to be able to help much..
Any ideas why the Travis check is still "Waiting for status to be reported"?
> @maartin0 you can ignore the WSL failures, but the travis failures seem real - you may need to remove the local `.nvmrc` after your `--save` tests, to leave a...
Looking more at that output it looks like `make_fake_node` is getting`node` handled as an alias for `node-v0.1.14` which seems odd