Cedrik Neumann comments

Results 20 comments of


                                            Cedrik Neumann

fix: open file in read mode and close on cleanup for ElasticsearchPublisher

New PR based on https://github.com/amundsen-io/amundsen/pull/1772

fix: open file in read mode and close on cleanup for ElasticsearchPublisher

Can someone take a look please?

fix: open file in read mode and close on cleanup for ElasticsearchPublisher

> @m1racoli have you considered moving to use the new elasticsearch task? https://github.com/amundsen-io/amundsen/blob/main/databuilder/databuilder/task/search/search_metadata_to_elasticsearch_task.py Oh, that's interesting. We will take a look. Thanks!

Support MkDocs themes

It would certainly help to be able to output real markdown files instead of rst formatted ones.

Support for custom environment variables

This would be really nice. We have some environment variables, which are virtual env specific, and would have liked to be set when activating the environment. Those variables could be...

Google Operators don't support all authentication parameters

Thanks! I am not sure I managed to discover all cases. My findings are based on the search for `:param impersonation_chain:` in the doc string. The BigQuery and GCS sensors...

feat(scripts): provide `diagrams` CLI

@mingrammer Let me know, what you think about this PR :)

feat(scripts): provide `diagrams` CLI

@gabriel-tessier > But what about returning the name of the file(s) generated instead of 0 which can be useful if you use another tool to communicate and for unit test!...

fix: open file in read mode and close on cleanup for ElasticsearchPublisher

Independent of the new class, what's missing for this PR to be merged?

changelog --subdirectory

What about a tag format like ``` submodule-v1.2.3 ``` which represents version `1.2.3` of the module in `submodule`. This would be nice in a monorepo setup. It's done like this...