Markus Mirz
Markus Mirz
@martinmoraga @dinkelbachjan Should we fix this in cimgen so that the error does not appear again after generating new code?
Yes, we should merge it. It looks like it is ready. I won't be able to check it before the weekend. So feel free to add your review :-)
@martinmoraga could you please add the dco sign off? Then this can be merged.
> Has this been fixed in CIMgen? Fixing it just here wont help anybody in the long run as the changes will get lost when the code gets regenerated. I...
@georgii-tishenin I also prefer interface classes without member variables. One issue that we have in dpsim is a deep inheritance hierarchy, each hierarchy level adding new member variables. Due to...
WIP ```codeowners /.dockerignore @m-mirz /.github @m-mirz /.editorconfig @m-mirz /.gitignore @m-mirz /.devcontainer @m-mirz /CMakeLists.txt @m-mirz /README.md @m-mirz /cmake @m-mirz /docs @m-mirz /dpsim-models @m-mirz /examples @m-mirz /python @m-mirz /requirements.txt @m-mirz /setup.cfg @m-mirz...
@stv0g no problem. Maybe it makes more sense to do it like in villas node? https://github.com/VILLASframework/node/blob/e26a5c1b48e4746839a83a8f942ac75cca25b3d2/CODEOWNERS#L8 This reduces the probability that a file is not covered by the CODEOWNERS file...
@stv0g I have moved my branches to my fork as commented in the other PR. Before you delete branches, please let me know which ones. I would like to store...
@stv0g I have stored all of the branches above in my fork as well. So, you can go ahead deleting them if you do not receive feedback.
> The branch 'IterativeMNASolverDirect' has been recreated in my fork and can be deleted here! > > The branch on my fork somehow compares with the one here though, I...