Mikhail Burshteyn comments

Results 35 comments of


                                            Mikhail Burshteyn

Produce better assert error messages

This should be relatively easy to do if limited to comparisons only (or maybe comparisons and logical operators), but will probably get a lot harder if we want to break...

Set of rules to lint `pytest.ini`

NB: since pytest 6.0.0, the options can also reside in pyproject.toml. [Docs](https://docs.pytest.org/en/stable/customize.html#configuration-file-formats)

PT019 and pytest-describe

Hi @ROpdebee, Thanks for the report! I'm not really familiar with pytest-describe and its naming conventions, but I'll see what I can do to fix this.

I looked at pytest-describe, and it's more complicated than that. Full support would also mean supporting tests imported into a describe block via [`@behaves_like`](https://github.com/pytest-dev/pytest-describe#shared-behaviors). And even if we ignore `@behaves_like`,...

Rule to support deprecations: tmpdir->tmp_path && tmpdir_factory->tmp_path_factory

Another example of a deprecated fixture is `mock` -> `mocker` from `pytest-mock`.

Rule to disallow assertions in fixtures

@sobolevn These cases are not what I meant. If the fixture function returns a function which has some assertions in it, that is fine, since the function is called during...

Rule to disallow skipped tests

Thanks @sobolevn, I've added it to the description

Does not recognize size 1 tuples for names in @pytest.mark.parametrize().

Hi @cansjt, Thank you for your report! This is currently working the way I intended: when there is a single name, the plugin always expects it to be a plain...

Forbid to use `pytest.mark.xfail` without a `raises=` argument

In any scenario, if we expect a test to fail, it is best to pin **how exactly** we expect it to fail, so that it will be noticed if something...

Check for `allow_module_level=True` in module-level `pytest.skip`

Hi @sobolevn, I'm not sure that duplicating `pytest`'s runtime checks on the linter level is the way to go. Linters and tests are typically run in the same CI pipeline,...