Lyndon Homewood
Lyndon Homewood
>Source generated XMLDOC showing bindings and interactions on an action I assume we can only generate this for the strongly-typed wrappers on the built in actions. I'm slightly concerned we...
> if (Input.IsActionUp("Fire")) I fine the naming IsActionUp slightly confusing. Is this on the up edge or just not pressed in general. I think its the up edge but I'm...
>InputActions.fire.TryGetInteractionParameter((HoldInteraction x) => x.duration, out var duration); This is quite a long function name - would TryGetInteraction be sufficient ? Ignore me - this obviously clashes with the other term...
What does this property represent? It was the only one that wasn't intuitive to me. `public static Vector2 mousePresent { get; } `
> @lyndon-unity It's meant to represent whether a mouse is connected or not, but should have had a bool return type. It would be good to be consistent with the...
> Initially it was called mouseConnected but it ended up as mousePresent for two reasons. One, familiarity with the legacy API which also calls it mousePresent, and two, a 'mouse'...
There are several test failures which seems to highlight problems with this change.
I think the code in this PR supersedes this https://github.com/Unity-Technologies/InputSystem/pull/1834
> > I've moved all key changes over into the other PR so this one shouldn't land. > > @lyndon-unity What exactly was moved then? Does this imply the regression...
We seem to lack migration info for GetPenEvent, GetLastPenContactEvent, ResetPenEvents, ClearLastPenContactEvent All could refer to Pen.current