Jonas Zeiger

Results 22 comments of Jonas Zeiger

Related to issue #3278 because timeouts were supposed to save us from the hang if they really were effective.

Installing Node 18.x could look as follows (based on a `debian:12` or `debian:12-slim` image with `curl` and `gpg` installed in a previous step): ``` ENV NODE_MAJOR=18 RUN echo "Installing NodeJS..."...

Thank you for simplifying the reproduction. I wasn't able to reproduce without enabling taxonomies in my setup. Maybe due to my theme. On Wed, Dec 6, 2023, 05:39 Joe Mooring...

I think the problem is that `toc.go` insufficiently accounts for child nodes. Still, I'd love to fix this issue in a forward oriented way (addressing all the linked issues) and...

It seems like the rendering test fails, because the output is **more correct** now: ```diff ... line diff (-got +want): []string{ "\n", " \n", " A < B & C...

@jmooring I applied the following changes to fix the test and be more aligned in general: - Also pass rendering options (`HardWraps`, `XHTML`, `Unsafe`) to the TOC rendering extension -...

> The xhtml and unsafe options are already honored when rendering a TOC entry, and you would never have a newline within a heading so the hardWraps setting is irrelevant....

These three issues should be properly fixed now, testsuite passes: - https://github.com/gohugoio/hugo/issues/12022 - https://github.com/gohugoio/hugo/issues/7169 - https://github.com/gohugoio/hugo/issues/11783 @jmooring Please review.

I am also on Linux. I will try to find your fix and quickly test it.