lukstbit
lukstbit
There are build errors.
@Jatin887 You should add the code to enable viewBinding to all of your PRs. If you place the lines on the same position you shouldn't get a conflict and we...
@Arthur-Milchior Build failure: `e: /Users/runner/work/Anki-Android/Anki-Android/AnkiDroid/src/main/java/com/ichi2/libanki/sched/Sched.kt: (162, 20): Unresolved reference: HashUtil`
I'm for dependency injection as this would be a step towards some sort of architecture where everything is not tied to everything. However I'm not sure this PR is the...
> What do you mean by this? Aren't they being used inside the activity? They are just that ideally you'd use this injection in other places as well, most notable...
@UvrajSB I've ran your code and I noticed that changing the application theme in settings(to light as that is what I use) doesn't change the theme for `DeckPicker` that you...
@UvrajSB Out of curiosity I tried implementing the splashscreen in IntentHandler and didn't manage to do it. In the latest versions it kind of works but doesn't even show the...
Whenever we migrate to coroutines we should make sure we are able to inject/replace the dispatchers used to make testing easier.
@sauravrao637 Yes, the minimum you can do is passing the dispatcher to the `countModels()` method: `suspend fun countModels(col: Collection, dispatcher: CoroutineDispatcher = Dispatcher.IO)` and then using the new parameter. The...
@sauravrao637 The instrumented tests are known to be flaky and I've seen the same failure for unit tests on windows in my own PRs so I don't think they are...