lukinovec

Results 36 comments of lukinovec

> After [f2d562c#r82301420](https://github.com/archtechx/tenancy/commit/f2d562cd8b81255877d14ecb92f351e9c78d8b4f#r82301420) is done, let me know if I can do a final review and merge this. Done👍

> Moving this convo here since discussions on commits are messy (not sure how the reviews got applied to the commit instead of the PR) [2594b19#r82107711](https://github.com/archtechx/tenancy/commit/2594b1960fbf663b02292c9740e11977ba313f37#r82107711) > > Do our...

I've looked into this, and I couldn't find anything else than [this solution](https://github.com/archtechx/tenancy/issues/929#issuecomment-1246946861). In the `SanctumServiceProvider`, the route is hardcoded along with the middleware, so we either have to override...

After I moved the event dispatching to the try block, the CI tests started failing because no exception gets thrown, and that's weird because on my device, the test works...

@stancl, the test is failing because if a tenant's database doesn't exist, it gets automatically created while running the `Migrate` command (if we're using MySQL or SQLite). The test also...

> I don't think the DB should be created in `Migrate` when using MySQL. The migrate job fails or doesn't run if the DB doesn't exist. Could you link to...

> I'm pretty confused by the part where it creates the DB because that'd defeat the point of this PR. Yeah, I had trouble understanding the point of the requested...

> Ah, does it only do that in tests? It does that every time the app environment is `local`, so no, not only in tests (I mean the app doesn't...

@stancl I resolved the conflicts and assigned the PR to you

@stancl, I resolved the conflicts, there are some failing tests, but these are the same as the ones that were failing before the merge, so that's fine.