Luciano Leggieri comments

Results 4 comments of


                                            Luciano Leggieri

Feature request: use 'fast-json-stringify' to encode span into a json

I can try. I have to fetch the actual schema. I have some doubts on what's allowed on a tag.

Feature request: use 'fast-json-stringify' to encode span into a json

Currently blocked on https://github.com/fastify/fast-json-stringify/pull/209

Feature request: use 'fast-json-stringify' to encode span into a json

Processing the span on line https://github.com/openzipkin/zipkin-js/blob/7039cafbfffe521b0b2a024f50f33e3d47001e9f/packages/zipkin/test/jsonEncoder.JSON_V2.test.js#L50 in a loop 10 million times gives the following results: - JSON.stringify: 13491 milliseconds - fast-json-stringify: 6611 milliseconds

Prevent [ERR_STREAM_PREMATURE_CLOSE] error log when intentionally closing a stream before end

> error doesn't seem to originate on the stream object received from the call to the database, I suspect instead that this can originate from another stream that is writing...