Luke Massa
Luke Massa
We could also add a handler on "error", which would help with situations where the page loads but failed to connect to the websocket (which I see sometimes if you...
I think this is a similar issue to the one I am in the process of addressing here: https://github.com/runatlantis/atlantis/pull/3747. The issue in this case is this I believe here: https://github.com/runatlantis/atlantis/blob/79dfa83612cd65c4f97d35dd0d972a3e0029d67b/server/events/apply_command_runner.go#L210....
Looking closer at this, I'm trying to decide whether this is a general problem or a gitlab one. Particularly, it looks like the current behavior if you plan two projects...
> I use github and `pending` is something that is running, waiting for a status to be reported; this happenes with all github actions. > > Pending should not be...
@glasser thanks for the contribution! I think this is definitely a step in the right direction. I've recently been a bit worried about the growing number of configuration options to...
> I do like the idea of preserving (say) the last page. That said, you can also view the full log at the web UI anyway, right? Which in practice...
Ah sorry, I should have been more clear; I was just offering my opinion, I don't have any authority on the matter :) I'll let @jamengual take it from here...
I like the idea here of having a generic logging mechanism, I think that's definitely a better way of handling large logs rather than posting dozens of comments in PRs!...
I looked into this closer, and didn't realize that gitlab (the VCS I use) allows 1M characters per comment, whereas github only allows 65k! I have some relatively large plans...
My opinion is we should still pursue this PR with a few tweaks: 1. Frame this option in the comments/documentation not as a feature to enable large logs, but an...