lukelee-sl
lukelee-sl
> > Seems reasonable but should there not be a HAPI test to show that the transaction reverts as outlined in the original issue? > > Hey @lukelee-sl Thank you...
Tracking issue in the the services repo - https://github.com/hashgraph/hedera-services/issues/11508
This HAPI test shows that a transfer involving hbar, ft, and nfts https://github.com/hashgraph/hedera-services/blob/develop/hedera-node/test-clients/src/main/java/com/hedera/services/bdd/suites/contract/precompile/AtomicCryptoTransferHTSSuite.java#L641 other tests show that allowances to the contract are respected for `CryptoTransfer`.
`AbortException` has been removed. The `HandleException` issue still needs to be addressed
Work is in progress. Closing this until further work is assigned.
Need reviews for this notion page https://www.notion.so/swirldslabs/Contract-Admin-Key-1057c9ab259180838de4fbcfdda33783?pvs=4
Explore in this notions page https://www.notion.so/swirldslabs/Contract-Admin-Keys-1057c9ab259180838de4fbcfdda33783?pvs=4 Epic to fix issues are in task #15990 Closing this issue as duplicate
xTests are no longer
Check for relevance to the forking work for the services node.
> Seems like this check already exists. @lukelee-sl Services [reference here](https://github.com/hashgraph/hedera-services/blob/2f5ca38b2ceb8f5743edc8455c1ba011f942ddd6/hedera-node/hedera-smart-contract-service-impl/src/main/java/com/hedera/node/app/service/contract/impl/exec/operations/CustomSelfDestructOperation.java#L91-L92) Besu [reference here](https://github.com/hyperledger/besu/blob/d2b42d56d84e41e2be0b77c0ba4c842fba027455/evm/src/main/java/org/hyperledger/besu/evm/operation/SelfDestructOperation.java#L72-L76) > > Is this it, or am I missing something? @MrValioBg, Good point. For one thing...