Luca Giacomel

Results 17 comments of Luca Giacomel

+1 confirm that I have this issue as well. will try to see if I can find a patch

@igorbarinov To be honest I am currently playing lego using Keras very little value on my side. I use the functions to retrieve the dataset from this project (BatchDatset, TestDataset...

Yes, static methods for the win here. I am not sure how useful it would be to have this on multivariate distributions (there might be usecases but they don't pop...

I am curious to see if this persists after my latest fixes in seasonality, can you try re-running this @BjorHart ? Best

This seems like a real bug, well spotted. Investigating as it might be a major improver of the quality of the seasonality fitter

Yes, I just verified it :) working on a fix

very happy that this also solves an issue with multiplicative seasonality not behaving as expected, adding a test for this :)

So the issue should be resolved on master (I didn't deploy the pakcage to pypy yet though). I am running this code for testing this: ``` z = np.sin(np.linspace(0, 200,...

Hi @BjorHart, that's not correct actually. What 709 does is to set the seasonality, say in case you do 8 it will be: `f_{period}_{order}_{sin/cos}` starting from 0 to 7 (that's...

Is this with the code on master?