Lukas Radermacher

Results 38 comments of Lukas Radermacher

We don't think that this should be part of this repo. In our opinion, the compose file in this repo serves the purpose of illustrating a minimal deployment with just...

I've just noticed that this issue is just the opposite of #148, where you explicitly removed the responsible groups from the "visible for" list. Nevertheless, I'd suggest to at least...

The log is only visible to admins or members of a group with "Manage Ephios" permission. I would wish that log entries related to events (sign-ups, confirmations, …) are visible...

Thank you for the feedback! > The code is a little brittle I think. Having to remember to make the move optimistic is something I'd rather not have as it...

> But this is definitely nothing for this PR Moved to #1075

> Hm, I see what you mean. What side effects would you expect from this function, though? Potential side effects would be features like: - Undo-able moves (e. g. showing...

Logs of a model that are attached to another model (`attach_to_func`, e.g. `ResourceAllocation` to `Shift`, see ) should also show this association in the log. Currently, attaching a log to...

> > After #1158, the lockfiles were not up-to-date and running npm run install:all caused changes to them. > > Shouldn't [`npm ci`](https://docs.npmjs.com/cli/v9/commands/npm-ci) have caught those changes and let the...

> @lukasrad02 There seems to be an issue with glob now. Yes, I'm aware. But that is not in scope of this PR. I was already planning to resolve the...

We also though about integrating this feature with the existing transfer points, but this has the drawback of ambiguity if a transfer point is part of either no or multiple...