Lukas Malkmus
Lukas Malkmus
Ok, I'll try to come up with something over the weekend.
Similar issue: https://github.com/stripe/stripe-go/issues/710 and the solution: https://github.com/stripe/stripe-go/pull/711/files#diff-f34528b48beca228ad5851464b3e20496f8c34c1f7b663e7f109fa9f5ed02fc4R328-R338.
@treilik Not sure you're aware of this, but the test fails in CI.
Ups, yes. Should have just looked at your changes :) Looking forward to your solution :)
Looks good to me, but I'm not that deep into the materia :) Make sure to fix the linter issues which are annotated in the `Changes` view and probably ask...
Do you mind me bringing up a branch and trying some stuff out over the holidays? Would love to play around with the beta and have a proper use case....
And I didn't know you were using your own genny fork. Might want to tag it using `tools.go`.
I weren't able to implement anything usable yet, however, when using your genny fork I noticed it procudes different code than the one checked in manually. For example the casing...
In `context.go` you import this: ```go import "github.com/janeczku/rancher-letsencrypt/letsencrypt" ``` But you did your changes in: ```go import "github.com/solocommand/rancher-letsencrypt/letsencrypt" ```
Make the CircleCI test pass. Looks like it fails because a dependency is missing. I have no glue how dependencies are manage here, but looks like you need to add...