Lukas Kurz

Results 25 comments of Lukas Kurz

> It's not a reason for landing code that doesn't yet meet our standards. Does this mean you don't see this PR being merged to address the issue ? I...

> Also not without understanding how it will interact with HC, since as mentioned above we are currently planning on switching the plugin to HC shortly, which apparently completely changes...

> @lukaskurz Are you planning on updating this PR per the comment above? I was (still am somewhat) held up by some other stuff, but I would like to see...

@stuartmorgan As you requested, I added a check to ensure this workaround is only used with Renderer `LEGACY` and not with `LATEST`. I changed the workaround to a use a...

I'm not sure whether the maintainer of this repo is still active :man_shrugging:

Same here ``` /home/lukaskurz/.pub-cache/hosted/pub.dartlang.org/launch_review-3.0.1/android/src/main/java/com/iyaffle/launchreview/LaunchReviewPlugin.java:11: warning: [deprecation] Registrar in PluginRegistry has been deprecated import io.flutter.plugin.common.PluginRegistry.Registrar; ^ /home/lukaskurz/.pub-cache/hosted/pub.dartlang.org/launch_review-3.0.1/android/src/main/java/com/iyaffle/launchreview/LaunchReviewPlugin.java:41: warning: [deprecation] Registrar in PluginRegistry has been deprecated public static void registerWith(Registrar registrar) {...

if u check one of the official repos, like `battery`, they do the same https://github.com/flutter/plugins/blob/master/packages/battery/battery/android/src/main/java/io/flutter/plugins/battery/BatteryPlugin.java

How is this still not merged? Nearly half a year since the creation of the PR has passed, without any direct feedback of the maintainer @Lyokone . I understand that...

@akhatriST I just forked the repo, merged the contents of all the PRs which were needed and use that repo for now.

I am going to close the PR for now, since the old fix no longer works on the new flutter version and I don't have the time to finish developing...