Luís Dalmolin

Results 49 comments of Luís Dalmolin

I think method injection would be cool if we have a way to "SelfHandling" the commands, like L5. So, a `handle` method in the `Command` class will make sense to...

Hi @dmikam, thanks for the contribution. Would you mind adding some tests covering the new features you are adding? I don't feel comfortable merging this code without test coverage.

Also, seems like your changes broke the existing tests, so definitely we need to adjust a few things here.

@wangarrius are you using the latest version? Just to make sure. I'm going to take a look at this if so

> The joins do not consider if the relationship they are pointing to belongs to another database (within the same server). What would you expect to happen in this case?...

Yeah, the prefix can and should get automatically applied. The connection can be tricky because if it's not on the same DB server, it would fail. So maybe a way...

Are you sure about this? Can you describe your current table structure and also give an example on how you are calling the join relationship method?

@saibotk Seems like a valid feature request. I'll take a look at this when I have some time, probably next weekend.

@chWagnr Can you push this failing condition into a git repo so I can replicate the issue?

@rabrowne85 Sorry it took me this long to check your PR. If you could write a test case for this it would be good.