Lucia Camacho
Lucia Camacho
Thanks for fixing this! The fix already landed in nightly, in the mean time `rustup toolchain install nightly` fixes this.
Small complication: it seems that `nix flake lock` calls [fetch](https://github.com/NixOS/nix/blob/8fb36a98ffae53683cb55165578adab21d8bbd8d/src/libfetchers/fetchers.hh#L79-L83) which in turn calls `Input::fetch` -> `InputScheme::fetch` -> `fetchToStore`. In other words, I don't currently see a way to: -...
> What use case do you have in mind? Isn't LFS typically for large files, that wouldn't usually affect evaluation anyway? `builtins.fetchGit` populates the nix store with a `-store` path....
In general I agree, but (afaik) other fetchers can't use git credentials.
Thanks for the thorough writeup @roberth ! I owe you all an update. To avoid shelling out and implement some features we need to merge, I need a subset of...
Thanks for offering to help @kip93, I'll very happily take you up on that! Here's some background on fetchers (sorry if you already know all this). `SourceAccessor` abstracts over fs-like...
Ok I don't think we need to touch `GitExportIgnoreSourceAccessor`! [In it's constructor](https://github.com/NixOS/nix/blob/f4962fe59b5e624dfe62a922782c6a1b44d683a4/src/libfetchers/git-utils.cc#L772), it takes an instance of `SourceAccessor` but in reality we always pass in `GitSourceAccessor` there - so the...
> neither CFSA or FSA define any constructors that take a lambda as second arg, friends I show this to say it shouldn't compile ended up figuring this out, but...
oh not super important but if you have a sec @roberth - is this the right way to run the e2e nixos tests: `nix build --impure '.#hydraJobs.tests.fetch-git' --show-trace` ? I...
Except a URL parsing quirk I think it's ready! Added an e2e test and fixed some parsing, will be back tomorrow to touch it up. Currently the filter attribute matching...