Łukasz Ślusarczyk

Results 39 comments of Łukasz Ślusarczyk

Distributed Ranges branch is ready to be reviewed by oneDPL developers. It passed all existing oneDPL CI tasks: https://github.com/oneapi-src/oneDPL/actions/runs/9128713306 It passed our tests executed by CI running in our repo...

@akukanov It seems we addressed all comments that you had so far. Are there more comments? If not, then could we please work toward merging this code to main branch?...

> This is a first pass with higher-level comments. @julianmi , thank you for review. I've applied and answered all your comments. Please resolve discussions which you think I addressed...

@julianmi , I've applied unresolved discussions from yesterday. Please check if all is ok now and resolve what is ok.

@akukanov , all, Here is [documentation of Distributed-Ranges API](https://oneapi-src.github.io/distributed-ranges/spec/index.html) which you may both use as a help during review and you may review it itself checking if it is clear...

> A couple of comments regarding the CI. @julianmi , thank you for your valuable comments. In https://github.com/oneapi-src/oneDPL/pull/1663 PR I've refactored Distributed Ranges CI to be tested in the same...

@danhoeflinger , thank you for the review and valuable comments. I've applied or answered all of them except https://github.com/oneapi-src/oneDPL/pull/1479#discussion_r1670894363 , which needs some more work and experiments from my side...

> In this PR we have a lot of destructors, declared as `= default`. I understand why we need that in case when destructor also declared as `virtual`. But for...

analysing the failure, currently on Borealis shp-benhc times out, on devcloud my account expired, running locally - out-of-mem (seems shp-bench ignores in some cases vector-size - fixing it...) in progress...

ExclusiveScan benchmark in shp fails. See: https://github.com/intel-sandbox/libraries.runtimes.hpc.dds.dr-ci/actions/runs/6703645628 Exact command: ``` ONEAPI_DEVICE_SELECTOR='level_zero:gpu;ext_oneapi_cuda:gpu' \ KMP_AFFINITY=compact shp/shp-bench --vector-size 2000000000 --reps 50\ --benchmark_out_format=json --context device:GPU --context model:SHP --context runtime:SYCL\ --context target:SHP_SYCL_GPU --v=3 --benchmark_out=dr-bench-adc021a8e9a64a6c86da243e79fcb338.json\ --benchmark_filter=.*Sort_DR\|Gemm_DR\|^DotProduct_DR\|^Exclusive_Scan_DR\|^Inclusive_Scan_DR\|^Reduce_DR...