Laurence McGlashan

branch: git_branch_create allows creation of branches with invalid names

1

### Reproduction steps Using git_branch_create, it is possible to create branches with invalid names. There is a function called git_branch_name_is_valid but it's not used inside git_branch_create. Presumably we can either:...

git_submodule_update should call git_clone__submodule instead of git_clone to omit the path check

1

### Reproduction steps 1) Create a repository that has a submodule called "mysubmodule". 2) Change directory to a folder which has a subfolder called "mysubmodule". 3) Clone the main repository...

GIT_EBAREREPO is supposed to be used for operations that are not allowed on a bare repository. But in this case it's the opposite and the operation is not allowed on...

…C for submodules Fixes #6963

Handle cases where content length of an http response is zero

10

Closes #7090 Closes #7070

indexer: Initialise all members of git_indexer_progress

1

I have a push_transfer_progress callback registered when calling git_remote_push, where I forward on the "bytes" argument to some progress reporting. For local pushes, the received_bytes member is uninitialized. If you...

schannel: Fix certificate error reporting and ignore some trust errors by default

2

This is a partial fix for #6724. 1) dwErrorStatus is a bitmask and so I've attempted to concatenate the error strings. 2) libgit2 now uses the same defaults as Git...

submodule: git_index_add_bypath does not move conflict entries to REUC for submodules

1

Because of the early return after git_submodule_add_to_index [here](https://github.com/libgit2/libgit2/blob/3251d1bb62b8c420988d16c098c48ac463f548b0/src/libgit2/index.c#L1616), [index_conflict_to_reuc](https://github.com/libgit2/libgit2/blob/3251d1bb62b8c420988d16c098c48ac463f548b0/src/libgit2/index.c#L1621C13-L1621C35) is not called when the path is a submodule. I can workaround this by calling git_index_conflict_remove after I call git_index_add_bypath. I...

The switch statement isn't hit because of the early return: https://github.com/libgit2/libgit2/blob/a6ee48d4e36f68285d4040df2bff22407745056e/src/libgit2/transports/ssh_libssh2.c#L597 It is unrelated but found this as a customer is hitting "failed to start SSH session", but only for...

First attempt at fixing #7158. However a test sporadically fails: ``` ❯ ./libgit2_tests -scheckout Loaded 385 suites: Started (test status codes: OK='.' FAILURE='F' SKIPPED='S') .........................F...................SSSSSSSSSSSSS........SS....................................................................................................... 1) Failure: checkout::crlf::with_ident [/local-ssd/lmcglash/Bteams/mw_libgit2/tests/libgit2/checkout/crlf.c:360] crlf/lf.ident...