Lane Rettig

Still work in progress, do not merge. I'm working on improving the master README and bringing in some of the excellent content from the benchmarking report.

Remove revision number from top-level README

8

Nothing in this doc is versioned and it's confusing to lead with this. Let's just version the actual specification docs (https://github.com/ewasm/design/blob/master/contract_interface.md, https://github.com/ewasm/design/blob/master/eth_interface.md, https://github.com/ewasm/design/blob/master/system_contracts.md).

Compile error: Block.cpp:103:11: error: explicitly assigning value of variable of type 'dev::eth::Block' to itself

1

I'm trying to compile v1.5.1 (linked in the [hera circleci file](https://github.com/ewasm/hera/blob/master/circle.yml#L87)) on OS X using clang version 10.0.1: Apple LLVM version 10.0.1 (clang-1001.0.46.4) Target: x86_64-apple-darwin18.5.0 Thread model: posix ``` [...

Opening as a placeholder to implement support for smart contract (app) events. This could not be implemented in the API since go-spacemesh does not support this yet: https://github.com/spacemeshos/go-spacemesh/blob/aa7eb73e121e7746de3468d1a365523dc729e3fb/api/grpcserver/globalstate_service.go#L301-L308 CC @YaronWittenstein

Record ATX timeliness, don't reward late ATXs

6

## Description Verifying tortoise and self-healing rely upon knowing whether ATXs (referenced by voting blocks) were received on time, in order to properly assign weights to votes. (See #2540.) In...

Genesis address format

3

See https://github.com/spacemeshos/pm/issues/140 - [x] choose and import a bech32 implementation (see [this list](https://github.com/spacemeshos/pm/issues/106#issuecomment-1171613630)) (chosen github.com/cosmos/btcutil) - [x] use this to write a simple address parser (string -> `Address`) with error-handling...

Initial PoST proof challenge should include nodeID

1

Shouldn't it? The setup provider does check that the metadata matches, but the nodeID is not included in the initial challenge. Doesn't this mean that the initial PoST proof is...

Replace float64 with fixed point arithmetic

3

We're already using fixed-point arithmetic in hare, see hare/eligibility/oracle.go. The only place I'm aware of this being an issue today is rewards: https://github.com/spacemeshos/go-spacemesh/blob/5234b07a2bff387ee83d3f5d7ef4ec66713333d3/genvm/rewards.go#L67-L75 But this code will be replaced anyway...

Evaluate fixed-point decimal arithmetic library

2

Currently we're using a custom solution: https://github.com/spacemeshos/fixed Consider switching to one of these alternatives: - https://github.com/shopspring/decimal - https://github.com/ericlagergren/decimal (used in https://github.com/spacemeshos/economics) - https://github.com/cockroachdb/apd See also http://speleotrove.com/decimal/ Related: #3408

Nonce arithmetic and types in sqlite

1

https://github.com/spacemeshos/go-spacemesh/blob/dd50f53d404055568c823748503b2d9427cbad38/sql/transactions/transactions.go#L187 On this line, and a few other places in this file, uint64 nonces are converted to int64 without checking for overflow. Can we add overflow protection here?