Lazar Petrovic
Lazar Petrovic
Thanks. It's not a must, but it's nice to have. On Sat, Dec 17, 2016 at 7:46 PM, Kasra Faghihi wrote: > Hi, > > I can do this but...
> My general thoughts on `Hash`: If we refactor `Hash` to an interface `ImmutableHash` could be a record. That would make it way easier to define it as a public...
> Lots of comments for your consideration. > > I don't think I've done so many code reviews for you. Perhaps not any! Anyway, so you know: My style is...
Long ago when we designed the consensus engine, we agreed that it would detect stale event internally. It would be a simple change contained within 1 component. So why use...
using real cryptography in unit tests can lead to very long tests, not sure if this is the best approach to take
I'm not sure this scenario that this test simulates is achieved with birth rounds, since the generator assigns birth rounds based on its internal consensus. I think we need an...
This failure seems to have been around for a while, but was not reported by JTR reviewers
I have a local reproduction. What I see so far, the system does not recognize the judges, so consensus can't continue.
@litt3 > * You're constructing a new signed state, but it's never being registered with the state garbage collector. I don't think creating a snapshot should cause a new signed...
@derektriley Is this PR supposed to have 600+ files changed?