Joel Low

Diff.find_similar! misreports binary files as different

1

Given the repository attached, and this small script: ```ruby require 'rugged' repo = Rugged::Repository.new('repro/.git') diff = Rugged::Tree.diff(repo, repo.rev_parse('309dd700bcfa6de727c43f159013f5b109412669').tree, repo.rev_parse('f010d6f0c3ede1d69ef387d63afc7cc334632c8e').tree, show_binary: true) diff.find_similar! puts diff.map(&:to_s).join("\n") ``` The resulting diff shows this:...

is_a? Confuses association consistency

8

AR checks that when assigning a variable to a relation (has_many/has_one) that the type of the variable assigned is consistent with the association. ActsAs overrides is_a?, which confuses this check....

Fix model reflection methods

3

This is used by simple_form and nested_form.

Implement compatibility with the active_enum gem

10

This implements some compatibility with [Active Enum](https://github.com/adzap/active_enum). The code probably isn't as clean as it can be; let me know how to improve. Thanks!

Implement gem configuration.

4

This can be overridden by using rake acts_as_relation:install and modifying the config/initializers/acts_as_relation.rb file.

mark_as_read! for ActiveRecord::CollectionProxies

7

Currently, `Model.mark_as_read!(Model.all.some_scope, for: current_user)` will raise ArgumentError, since the scope is not an `Array`. Can it be relaxed so that any `Enumerable` can be used instead?

Params conflict with UserEmail model

5

I have a user with multiple email addresses `UserEmail`; the Entity class would use: ``` ruby controller.params[identifier_param_name].blank? ``` Which would be a hash in the UserEmailController, and not a string....

Move configuration for identifier and token retrieval to the controller.

12

Addresses #207. I have not fixed the specs yet, because I'm not sure how the design will evolve. This allows for a per-controller configuration of where identifiers and tokens should...

Allow squeel to select table.*

3

I'm trying to achieve: ``` sql SELECT instances.*, count("instance_users"."id") AS user_count, count("courses"."id") AS course_count FROM "instances" LEFT OUTER JOIN "instance_users" ON "instance_users"."instance_id" = "instances"."id" LEFT OUTER JOIN "courses" ON "courses"."instance_id"...

Possibility of using nil? as a predicate

1

Currently squeel can only handle `column == nil`. It would be nice if it could also handle `column.nil?` I'm not entirely sure if this would create ambiguity in the DSL...