Łukasz Osipiuk

Results 53 comments of Łukasz Osipiuk

Sounds reasonable to me. If you are preparing a PR please just leave old configuration parameter which would serve as default value for the cpu/memory specific ones.

@wmoustafa do you think we can go with change to `com.linkedin.coral.hive.hive2rel.parsetree.ParseTreeBuilder ` proposed by @will-i-e? Seems easy to go but maybe you some fundamental problems with that approach?

@sopel39 YOu had some concerns regarding this one. Can you comment and/or approve?

@findepi, @martint I vaguely recall there was a discussion around this specific matter, not sure if conclusions were made. Is your memory more crispy?

> @losipiuk See [#13981 (comment)](https://github.com/trinodb/trino/pull/13981#issuecomment-1236842086) - I guess that's what you are thinking of. I meant something older - but this is a good summary. Thank you :)

> @martint is there any update on this. Should i close this PR ? @martint bump

> Alternatively, we should just skip buffering there and just rely on `OutputStreamSliceOutput` (which is accounted for and already does buffering) to do buffering instead. > > cc @electrum @losipiuk...

> > We can work around that by adding to airlift the MemoryAware interface which exposes the getRetainedSize method. The we can make the TrinoS3StreamingOutputStream implement that interface. > >...

It feels that the future returned from `FileSystemExchangeSource.isBlocked()` gets canceled. And when we are trying to compute the `ignored` [here](https://github.com/trinodb/trino/blob/4d235b0143051b04adda0e9d988a3521e1d5bedd/core/trino-main/src/main/java/io/trino/server/protocol/Query.java#L343) we get an exception. I did not yet figure out...

@linzebing When looking at the code I thought for a while that [this call](https://github.com/trinodb/trino/blob/561c301c0af6ade69c640320cb11c4709f92234e/plugin/trino-exchange-filesystem/src/main/java/io/trino/plugin/exchange/filesystem/s3/S3FileSystemExchangeStorage.java#L590) to `close()` could be the problem. As `close()` cancels the future which was returned from `isBlocked()`....