Lorenzo D'Ianni comments

Results 11 comments of


                                            Lorenzo D'Ianni

Introduce new option, closeOn, to override `$locationChangeSuccess`.

There are some news about this PR?

bug: Navigating to the app from an embedded WebView doesn't work in Android

I've the same problem but i detected that this happens only when a cordova plugin is used, so if I use a built in plugin like Geolocation the back button...

Add ability to toggle sidebar with responsive: true even on screens > 1024px

Hi @AzamatRasulov, yes sounds good! Currently I've not time to working on, if you want a PR is welcome!

Scroll in the sidebar

@Smiley32 yes, you are right! Now I haven't time for work on, so PR are welcome!

It would be even better if you could set width for a property

Hi @lmrwork, you can already change width via CSS, what is the use case that fit with JS and not with CSS?

feat: toggle sidebar in responsive mode | #15 #19

Before merge update all stackblitz examples, use demo.css from relative angular@version instead of master

fix: navbar overlap in mobile devices

Hi @Chetan-KK , thanks for the PR! Why did you choose 7rem? It could be too much on some devices What is the device/use case you need to fix?

Language Switcher Text Appears blurry

It's a Chromium bug [997322](https://bugs.chromium.org/p/chromium/issues/detail?id=997322) moved in status **WontFix** 1 year ago. I don't think that the chroumium team will fix it honestly.. We already tried to patch in #397,...

Fixed issue https://github.com/SidebarJS/angular-sidebarjs/issues/7

Hi @omelsoft, thank you for your PR! Can you move this PR in the [core](https://github.com/SidebarJS/sidebarjs) repo and apply your fix only in src files?

fix: welcome variable value

Hi @Chetan-KK, please update this PR with the new variable value described in [548](https://github.com/conventional-commits/conventionalcommits.org/pull/548#issuecomment-2429286987). Currently I see only linting changes.