David Loeffler
David Loeffler
No, that's the wrong thing: you should revert your changes to `noshake.json` and run `lake exe shake --fix` instead.
That's weird. If `lake exe shake --fix` is giving wrong results, I suggest that you restore the branch to the state it was in before you started the tree-shaking, and...
I have done some digging and I know what's causing this. Shall I push my fix?
Not quite. The issue is that `notation` declarations are visible to the parser, but invisible to `shake` (which only notices when the notation is _used_, not when it's defined). I...
Looks good to me now. If you're happy with it, please label with "awaiting review" and "awaiting CI", and I'll flag it for merging if the CI run passes.
maintainer merge
Thanks Michael and Sebastien for the reviews! bors r+
Thanks for the review, Filippo! I have applied your changes. I also fixed a minor formatting glitch in the module docstring, and added a mssing lemma `LSeriesHasSum_exp` that makes the...
Hi Michael, Thanks for the suggestions! I'm in two minds about this sort of thing (trading off concision / elegance vs. speed). CPU cycles are cheap, after all; and there...
Thanks Michael and Johan! bors r+