Locke Lin
Locke Lin
These code is duplicated with `VulkanReplayConsumerBase::WriteScreenshots`. It will be better if it could have a function for these two cases, `VulkanReplayConsumerBase::OverrideFrameBoundaryANDROID` and `VulkanReplayConsumerBase::WriteScreenshots`.
I'm not sure if the image on `vkFrameBoundaryANDROID` is from `vkGetSwapchainImagesKHR`. My option is quit simple that it could have a function, like `VulkanReplayConsumerBase::WriteScreenshots(ImageInfo* image_info)`. And then ``` VulkanReplayConsumerBase::WriteScreenshots(const Decoded_VkPresentInfoKHR*...
> Yes, I agree with this suggestion. Basically my question was about whether this change is compatible with virtual swapchain. As far as I can tell I think it is....
Sorry. That's a wrong click.
@marius-pelegrin-arm Please solve the conflict, and then it's good to merge.
The rest looks good to me.
My opinion about library levels is `decode -> compatibility -> graphics -> util`. Upper level could link lower level, but lower level couldn't not link upper level. `util` is that...
@werman could you please help me to test this PR https://github.com/LunarG/gfxreconstruct/pull/2088? I don't have a device that support `VK_KHR_present_id` and `VK_KHR_present_wait`. Thank you. Edit: Test sample: https://github.com/locke-lunarg/Vulkan-Tools/tree/present_id It requires Linux...
gfxr_vk-video-enc-test-n3070 is good. But gfxr_vk-video-dec-test-n3070 still crashed on `completed_.set_value()` of `vvl::Fence::Retire()`.
Yes. For now, I just removed `completed_.set_value()` to replay with vvl. It helped.