Lari Nieminen
Lari Nieminen
The above feedback is now addressed as best I could. I ended up keeping the default value as an empty string literal instead of NULL because the latter would have...
Latest comments should again be addressed now. Except, of course, no unit tests since I have absolutely zero experience and knowledge about them.
Files from VP's should work correctly now.
I'll reiterate that the Quenoth units should not be moved to core, at least not yet. They might still undergo **some** substantial changes, and moving them to core means having...
Feel free to make changes, no need to take them through me (and wait a long time doing so), unless you want input/ideas on a specific issue. Here's some thoughts...
I don't know if that code actually used to work (IIRC it was added in 1.13). But yes, the wiki does specifically mention that [trait] should be added **without** [modifications],...
I don't think it's possible to fix all the involved inconsistencies. Either you let the lich enjoy the defense of flat but somehow still be able to submerge in the...