Lucas Bollen

Results 10 comments of Lucas Bollen

I'm pretty sure this isn't ready to merge.

The currently existing unit tests don't check the correctness of the implementation, but rather that the generated HDL behaves the same as the Haskell model. I think we should change...

The same problem arises when evaluating a vector of bits, e.g.: ```haskell maybeHasX $ bv2v (deepErrorX "undefined bitvector" :: BitVector 8) == Just ```

^ Open for discussion of course, but given the fact that `clash-cores` is not officially released yet, I'd suggest not making separate functions for single lane and multi lane SPI,...

Had to add: ```rust extern crate alloc; use alloc::vec::Vec; ``` to `fuzz_injector`, which should not be a problem since it's for development and not production. @whitequark Feel free to merge...

@whitequark I think we're ready to merge :) But I have no rights.

> can you rebase and fix CI? Done, also changed `#[inline(always)]` to `#[inline]`

If we rewrite it to: ```hs class DriveVoid a where driveVoidFwd :: Fwd a driveVoidBwd :: Bwd a ``` We might want to consider adding a possibility to stall the...

Ideally after solving this we'd change https://github.com/clash-lang/clash-compiler/blob/master/clash-prelude/src/Clash/Signal/Internal.hs#L351 to return `Max 1 period` or similar solution to make sure that `DomainPeriod dom` is always at least 1 on type level.

Thanks for the quick response :). Am I correct that #593 allows you to create multiple instances of a hook? Because indeed that + the `manifest-path` option would then probably...