Lewis Marshall

Results 12 comments of Lewis Marshall

@Aagat I'm not sure what the issue is here, the tests seem to pass just fine for me: ``` $ git rev-parse HEAD a98aea1463c972506e302344ebbfa30f85b74f2f $ go test ./... ok github.com/flynn/go-tuf...

@Aagat I was running them against the committed files yes. I tried the latest Python release and there are a few changes which the Go implementation is not compatible with...

> The history code also converts to a generic map instead of the struct. Both should be changed to return the struct. I think this will need some form of...

@rgerhards I am shipping logs from quite a few different programs which format dates in a few different ways, here are some that I need to parse (the formats are...

> Or add support for the extra content-type, surely it's like one line of code Definitely advocate for that... https://github.com/ably/ably-go/blob/673864c17cce627bc09a283b953bd345458e52ca/ably/auth.go#L463

Just to add an extra data point, an example of using `authCallback` can be found in the [Serverless Auth Example](https://github.com/ably-labs/ably-serverless-auth) I wrote recently, specifically in [lambda/web/app.js](https://github.com/ably-labs/ably-serverless-auth/blob/main/lambda/web/app.js#L93-L134)

@umair-ably I assume that error parsing code should be using the same logic as when decoding successful responses: https://github.com/ably/ably-python/blob/dff73cd3bfe1ced08a10da1fa377f6247553568c/ably/http/http.py#L100-L105

@umair-ably yes, so that is msgpack, evident from the error "can't decode byte 0x81 in position 0", which from my many hours of inspecting raw msgpack is the start of...

@umair-ably apologies, let me explain. The realtime system supports returning responses encoded as either JSON or msgpack, and the SDK indicates which encoding it wants by setting the HTTP `Accept`...

I've proposed a fix for this in https://github.com/ably/ably-python/pull/571, since this came up as a problem in some internal testing too.