Lloyd Kupchanko

Results 17 issues of Lloyd Kupchanko

Continuing a discussion started in #435 The hsluv, hpluv, lchuv and hct color spaces currently allow angle units for their angle coordinate. As mentioned [here](https://github.com/color-js/color.js/pull/435#issuecomment-1948760359) this isn't [spec compliant](https://drafts.csswg.org/css-color/#color-function). Do...

Additional formats need to be added to the `hsl` color space in order to be [spec compliant](https://drafts.csswg.org/css-color/#the-hsl-notation). For example: `hsla(240deg 100% 50%)` fails to parse.

bug
spec-parity

For example, `srgb` and `hsl` have the same `gamutSpace` (`srgb`). Should gamut mapping `color(display-p3 1 0 0)` to `srgb` and `hsl` result in the same `srgb` color when converting the...

There are 13 tests in the old Chromatic adaptation test suite and 2 in the new test suite

help wanted
Topic: testing

There are 5 tests in the old Constructor test suite and 3 in the new suite.

help wanted
Topic: testing

https://github.com/color-js/color.js/blob/main/tests/contrast.html

help wanted
Topic: testing

The parse tests for none are failing because NaN isn't valid JSON. ![image](https://github.com/LeaVerou/color.js/assets/65072/87524755-a04d-4bdc-894b-4c1c8aa0c456) I can think of a number of different solutions: 1. change the tests to expect null 2....

bug
spec-parity

When running the color.js cli tests on Ubuntu 20.04/WSL2 running in Windows Terminal 1.18.2822.0 the test output is almost unreadable. ![image](https://github.com/LeaVerou/htest/assets/65072/209d2ae8-d6b7-4aa9-90e5-0efa29668490) ![image](https://github.com/LeaVerou/htest/assets/65072/89d95e3a-262a-47a0-9cec-c2494999c7e3) Commenting out the call to `logUpdate` fixes the...

bug