Lasse Mammen

Results 18 comments of Lasse Mammen

Another idea would be to use the OAS json schema to validate the entire document, see https://github.com/OAI/OpenAPI-Specification/blob/main/schemas/v3.1/schema.json - however, that may be too much tie-in and too big of a...

@Burstaholic I came across similar difficulties. I was messing with implementing Powershell instead of cmd, because output colours weren't showing up thus making msbuild output rather tedious to look at...

I'm seeing this too. Was something refactoring to do with logging that broke this?

@tuespetre Have you made any progress on this? We're looking to use it in production but performance-wise it's much slower than the process.start approach of integrating wkhtmltopdf.

Updated to pass linting and also add a comment to the merge request with a list of valid approvers as parsed from codeowners and change set of the MR.

Cheers @FlorianLudwig. I haven't had a chance to test this in prod yet, but will update our marge-bot installation later today and probably update this MR with anything I find....

Alright that's been done now. I've also updated the README file to reflect the changes

@carno I think it's pretty complete as is. The only thing I would say is that since last release Gitlab supports approvals (only optional not required) in the free version...

@nejch We are using this in production every single day, so I'm interested yes. I do think that sysadmiral's point is still valid regarding approval removal without impersonating. We use...

I've pushed support for using a combination of awards and approvals in CE edition. Haven't tested much in our production environment yet. This PR has been open for such a...