Lawrence Owen

Results 12 comments of Lawrence Owen

Perhaps instead of at the page level it could be done using the test controller: ```t.ignoreJSErrors(true / false)```

I'm receiving the following error on any firefox > 58.0 ERROR Was unable to open the browser "browserstack:[email protected]:OS X High Sierra" due to error. Error: API error undefined: undefined at...

I'm able to reproduce selecting multiple features getting picked using the sample.json provided, I can also reproduce it with other data sources i.e. https://www.nationalmap.gov.au/#share=s-gpC6cPOcnSVtAEo3HW1cV3ZxKK6 by zooming out and clicking near...

I believe this is a bug with cesiums picking when the features are clamped to ground, I've reproduced it [here](https://sandcastle.cesium.com/#c=nVTbbtswDP0VIU8JEMiOnbhJlhYb2mLAkKEFGqwY5j3IFu2olaVMkpOmRf999C1Lby/zgwWRPOTREcVUK+sISCk2Vgu+AmOYUNdGbwUHQ06Jgh05ByvKgl5+ENUffIpVWifaaSM7N4JbYGugmdHF7VFEDeygWwG71xV/1LZ+3Evr/blWDmFg4t6QPMWKkIRZWLI9mGuR3oOZk4xJC8PK5Zoa8xec0PPcFPU8wmHj1hiHxVmOTlxbEBGWGPhTCgOcOE0Kdg/ErYFstNznSJekkhWbytUi6oRVCmCc6IzYtd4JlSPI6DJfE+FIdXpSKhQsR5viFaQ5NLUpKKC51AnQmtUKSX1pOP1Tsz5bTb7TLL9Dc5uDM8dudGlQKso471catDJ+Bf3NanVxiKBSsyaCkLi3dm5j556XC+toLty6TEoLBks4UI6muvDknd6B8vwZH2dJkk5GPPAhDVk4naR+EMA0C0dhwD3Ddt50EgXZLOBR4s+mfDaFceSzMMh4Og5OZn4aAY+yyM/qepmQMKLuweGVNnyemqVReKW/1lrNiTMltBH4odiEIFa+cHieLp3EBnnfeq6lxhZpRal39Oflcnl1O6wkrWKfq2UQq6ZHSKfto9bFSvfzu0Erf6xumOIps05CpfZKa5kw8x1U2f9VAdtTOHhwc5S4u8RLxRIJ/HBYvEWQkGJMVqrUCa1If3CQgLxoDwtdL/SPW7qiVFOvUzb/D6pfCPv/5d2b0fDR1HhD6PfxO5daYY+VHDDDKJzSk+BkfJgfkrnOF05oGPnRwcVBOoZ2n/r+qM7XG/YW1u0lnHWEP4tio40jpZF9Sj0HxQYzgvWSEscDtrK1nVwL7xi64GJLBD99Z9JUjWgterJSyhvxCHHvbOFh/Bto9ajwzV9twUi2r8LWo7NlY6SULjzcvo90Tfu8yvwX) This issue looks related https://github.com/CesiumGS/cesium/issues/10091 . In the meantime you...

> Build error is due to `@types/react` duplication. Running `yarn-deduplicate` (https://github.com/scinos/yarn-deduplicate) will probably fix the yarn.lock duplication issue. Thanks Crispy! `yarn-deduplicate` failed to remove the duplicates so instead of opted...

Should additional definitions be a config Param?

> Looks good @ljowen - i have left some comments, will do another pass to check the feature picking. > > Just noting some things we should tackle maybe in...

Thanks @ggetz I did begin working on a unit test, will add it in a separate PR

Thanks @ggetz I've created a PR [#12132](https://github.com/CesiumGS/cesium/pull/12132)