Jiefan Li comments

Results 11 comments of


                                            Jiefan Li

Incorrect schema for views with unnamed columns in the view SQL

Thanks @shardulm94 for reporting it, opened a PR #214 to fix it.

Column '<table>.<column>' is ambiguous in Trino

I think the change to `com.linkedin.coral.hive.hive2rel.parsetree.ParseTreeBuilder` proposed by @will-i-e might affect the case preservation of Coral-Schema. @wmoustafa @funcheetah any thoughts?

org.apache.calcite.runtime.CalciteException: Failed to encode '中文' in character set 'ISO-8859-1'

Looks like it is an issue of the upstream calcite: https://issues.apache.org/jira/browse/CALCITE-3308, https://issues.apache.org/jira/browse/CALCITE-2616 it would be kind of hard to fix in Coral.

Failed to recognize predicate 'ARRAY'. Failed rule: 'identifier' in table or column identifier

@jixuekang could you please share the input SQL and full stacktrace?

Failed to recognize predicate 'ARRAY'. Failed rule: 'identifier' in table or column identifier

Hi @jixuekang , looks like your input is a Trino SQL, but `HiveToRelConverter` expects Hive SQL as input.

Coral-Schema: Make Coral-Schema compatible with both Avro 1.7 and 1.10

> Thanks for the comprehensive PR @ljfgem ! Could you also elaborate on point 7 of your PR description? As per avro 1.10, when is `default:null` expected? That would be...

Coral-Schema: Make Coral-Schema compatible with both Avro 1.7 and 1.10

Thanks @aastha25 for your review! @wmoustafa: do you want to take another look given it's a big change?

[Sample PR|WIP] Spark View Catalog with HMS and Coral

> Could you make the design doc public and link it from here? @wmoustafa Added in the description, but due to the org restriction, I can only share a copied...

[SPARK-39799][SQL] DataSourceV2: View catalog interface

Hi @jzhuge @holdenk, can we merge this PR? Or is there any other concerns?

[Coral-Hive] Support various shaded UDF resolution for one unshaded UDF static registration

> > A UDF is considered shaded if the prefix before the first dot contains an underscore. > > This convention is brittle. > > Why is shading indicated by...