goodliu
goodliu
Hello, I find when I call `With`, then `*zap.Logger` won't return a new child logger if the `Fields` parameters is empty. It looks a bit uncoordinated with `*Logger.WithOptions(Fields())`, so I...
previous merged refactor PR #201 “altered the external behavior of `With` method. ```golang // https://github.com/uber-go/zap/pull/201/files#diff-ff87b7c4777a35588053a509583d66c9f404ccbea9e1c71d2a5f224d7ad1323eL75 func (log *logger) With(fields ...Field) Logger { clone := &logger{ Meta: log.Meta.Clone(), } addFields(clone.Encoder, fields)...
I guess almost no one would use `With` with an empty 'fields', and they don't care whether the two Loggers before and after are the same. So people haven't been...
@piyongcai you can use `zapcore.AddSync` to wrap `lumberjack.Logger` : ```go // lumberjack.Logger is already safe for concurrent use, so we don't need to // lock it. w := zapcore.AddSync(&lumberjack.Logger{ Filename:...
@jekiapp current implementation of `gripmock` seem to only supports the ping-pong model of streaming, i.e. client can send multiple requests as a stream and server will respond to each request...
@tencent-adm 我们团队最近有个司内项目打算开源，想请问下怎么接入 license/cla 这个检查
已经联系到了相关开源同学，请忽略上述评论
Replacing squareNum with squareNumber does fix(I think this is caused by case sensitivity, what do you think? typo?). The table name `squareNum`, `squarenum` in the two SQL statements should be...
any updates?
Any updates? I encountered the same problem.