Jia Liu comments

Results 10 comments of


                                            Jia Liu

代码bug

future替换成completablefuture之后,改使用allof才是正解.

ORC-1200: Extracting encryption setup logic from `WriterImpl`

@dongjoon-hyun > 1. Do you have some documentation or reference in Apache Flink community? Yes, first we must create a stream based `PhysicalFsWriter` before `WriterImpl` initial. [WriterImpl](https://github.com/apache/orc/blob/7facf81846a5e4395f2dbab335faef93f04c6aee/java/core/src/java/org/apache/orc/impl/WriterImpl.java#L223) Then, You can...

ORC-1200: Extracting encryption setup logic from `WriterImpl`

What should I do next for this pr? I don't quite understand the meaning of it being marked as `Changes requested` state. :)

ORC-1200: Extracting encryption setup logic from `WriterImpl`

@dongjoon-hyun The PR description has been revised.

[FLINK-27805][Connectors/ORC] bump orc version to 1.7.5

@JingsongLi Could you help review this pr?

[FLINK-27805][Connectors/ORC] bump orc version to 1.7.5

I have submitted two pr to ORC community. [ORC-1200: Extracting encryption setup logic from WriterImpl](https://github.com/apache/orc/pull/1156) [ORC-1198: Add a new PhysicalFsWriter constructor with FSDataOutputStream parameter](https://github.com/apache/orc/pull/1153) I will refactor this part of...