刘冲 comments

Results 25 comments of


                                            刘冲

Suffixing names of boolean values with a question mark?

I do this on functions return boolean but not on boolean values 👀

Due to how extend works we can't replace type fields

Seems we need to keep multiple version of schema in this case, maybe we could added a "patcher" function. In fact, I've just defined another fake version of the exact...

Due to how extend works we can't replace type fields

@IvanGoncharov Great, thanks!

Moving the cursor in large files very slow

Same problem here, please try this file https://github.com/redis/redis/blob/unstable/src/module.c , it's very very slow 👀 @MaskRay

Is there any Roadmap available for the Hardware design or electronic Design?

Haven't see that for now, maybe this help? https://github.com/kitspace/awesome-electronics

Unable to fetch version 0.8.2 from clojars

+1 So the problem seems to be missing of protobuf-0.8.2.jar.md5 and protobuf-0.8.2.jar.sha, why not just re-upload the files?

Optional upload url for release events

I need this, actually I've made a similar change and then found this pull request 😹 Please merge 👀

Optional upload url for release events

I provided my solution, any one is ok for me to merge: https://github.com/actions/upload-release-asset/pull/45

Add capability of upload release asset via release tag

ping

Expose more Command create arguments

Ok, thanks for the explanation about the key locator. But how about the other arguments, the `command`, `arity`, `readOnly` and others...? Before the commit https://github.com/vert-x3/vertx-redis-client/pull/328/commits/8d45692283261df8faa4a3c86d1dc2229d57a42b in https://github.com/vert-x3/vertx-redis-client/pull/328, I implemented something...