Liran Ringel
Liran Ringel
Great! I’m quite busy these days, I hope I’ll find time this week to review this PR.
Ah, ok. Do you prefer some feedback now or should I wait?
It is definitely possible. I think `proc-macro-hack` does not support it, but I believe there isn't any true limitation there also. Perhaps we should no longer depend on `proc-macro-hack`, because...
@shymega @birkenfeld Indeed `std::io` is used here, not only for the error type but also the `Read` and `Write` traits are used (`Read` is used to read the input from...
> @liranringel are you fine with a MSRV of 1.45? Then we could drop proc-macro-hack. Yes, it's ok. > So one unfortunate point is that most of the `byteorder` features...
> I had a thought - what about this crate? https://github.com/technocreatives/core2 > > I know depending on external crates may not be ideal, but this would really help with the...
> It's useful as it's a `no_std`implementation of `std::io`. > > I've tested it on an XMODEM/YMODEM/ZMODEM I'm working on (WIP), and it compiles pretty well. The benefit for us...
Hmm on the other when I think about it, it may require users of `structure` to also make a conditional compilation. So perhaps we should introduce a new error type....
> Surely if we introduce the usage of `core2` in the main `structure` crate as an import, just like with `byteorder`, and use the same 'features' as we do before,...
> Sorry, I meant something like how `byteorder` is imported in the main structure crate. L137 to L138 on `src/lib.rs`. > > I was then thinking that if we're approaching...