liqun Fu

Results 33 comments of liqun Fu

@sconan32 thanks for trying CNTK C#. We still need to work on high level C# API to ensure that it matches python API. Before that, an easier way will be...

https://github.com/onnx/onnx/blob/main/docs/Operators.md#Split

This is a PyTorch onnx converter issue. Please create the issue in Pytorch and label it accordingly.

Hi @mdabros , that [Microsoft/CNTK#2374](https://github.com/Microsoft/CNTK/issues/2374) is fixed. If you are using CNTK from source, the fix is effective. If you are using CNTK NuGet package, the fix will be available...

please create the issue in onnx/tutorials. BTW, the tutorial script includes steps to download those files.

> Can you add unit tests? Also, why does the title say contrib op? Test cases are added to ONNX. These tests are run in CI. I disabled col2im_pads tests...

> Can you add unit tests? Also, why does the title say contrib op? Good point! @thiagocrepaldi already had test in this PR. I somehow removed the tests. I just...

> This PR will have a significant impact on converting librairies. Yes it does. For updated ops, I have added appropriate adapters for model converter. Anything else I need to...

> Shape inference caused by axes becoming an input is handled by taking Constant's value_ints as tensor during shapeinferencing. RE the process to decide which op qualified for such change,...

> Some nit comments. I saw some test_data_set_0 only has input_1.pb without input_0.pb. Is it expected? Since this PR really introduces a lot of test files (model.onnx, input/output pb files),...