Oliver Lipkau

Results 191 comments of Oliver Lipkau

Not really. Primary advantages are: * help devs to format code by storing `.vscode\settings.json` in the repo * enable enforcing of common styling * easier to review changes to code,...

> Or use .editorconfig so we're not tying people to an IDE. Or use both (as they are unlikely to change much). This helps with other stuff... EOL char, file...

> That's why I suggested using both that's what I do in my modules :-)

I would recommend **Stroustrup** references: https://en.wikipedia.org/wiki/Indentation_style#Styles https://github.com/PoshCode/PowerShellPracticeAndStyle/issues/81#issuecomment-285835361

If this can be defined, I can submit a PR by the next day :-)

sample: https://github.com/lipkau/BuildHelpers/tree/fix/harmonizeCodeStyle diff: https://github.com/RamblingCookieMonster/BuildHelpers/compare/master...lipkau:fix/harmonizeCodeStyle?expand=1

Any news on this?

I submitted a PR that should fix this: #61

can't this be closed?

As this changes the input parameters and returned object of `Invoke-Git`, this is a breaking change... although it fixes a buggy behavior.