LC
LC
Needs a rebase
> what are Dolphin Emulator's plans for moving to C++20? Honestly, I've wanted to move to it for ages now > And just how far should [[likely]] and [[unlikely]] be...
Code LGTM. Should be fine to merge once testing is done and whatnot
Whoops! Meant to close this once https://github.com/FEX-Emu/FEX/pull/2087 was merged, since that fixes this issue.
Just want to make sure if this is still relevant or needs any changes due to other merged android changes before merging (given it's been 9 months)
Yeah, making these static is fine imo, since they're non-mutable. The standard regex interface is quite lacking in various ways and is known to be a sore-spot (and I don't...
Personally I would just keep them as static const locals. Not really a fan of making them global/namespace-scope. I think them being kept local is more adequate, since these are...
How would I get the dff in order to test the failure? It doesn't seem like the website allows for that (unless it's tucked away somewhere non-obvious)
Hmm, poking at this, I'm not sure how to actually fix this (at least correctly). Though it is cool that converting it into a class uncovered an unrelated bug
build failures seem real